chore: allow production environment subject in slack-config STS policy - #81
Merged
Conversation
sds
enabled auto-merge (squash)
August 21, 2026 06:27
sds
added a commit
that referenced
this pull request
Aug 21, 2026
Removes the `ref:refs/heads/main` and `pull_request` subjects from the `slack-config` trust policy. Every job that rotates the Slack config token runs in a GitHub environment, so those subjects match nothing today — jobs with an `environment:` key always present the environment-form OIDC subject (#80, #81). Dropping them also tightens the grant: with `pull_request` present, any same-repo PR workflow job without an environment could mint a `secrets: write` token; now minting requires entering the `preview` or `production` environment, so any deployment protection rules on those environments gate token minting too. A future environment-less job that needs to rotate can add its subject back in a reviewed diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
repo:tempoxyz@211589300/tip.bot@1232143975:environment:productionto theslack-configtrust policy, the production counterpart to #80: theupdate_slack_appjob runs inenvironment: production, so its OIDC subject is the environment form and the existingrefs/heads/mainsubject does not match it. Without this, the production Slack app update would fail to mint once #79 lands.Also rewrites the subject comment to reflect that all rotating jobs run in environments; the ref/event subjects remain for any future job that rotates without one.